RFR: jdk8-tl builds windows builds failing in corba - javac: no source files

Bradford Wetmore bradford.wetmore at oracle.com
Thu Oct 17 01:55:55 UTC 2013


Updated webrev:

http://cr.openjdk.java.net/~wetmore/8026762/

Brad




On 10/16/2013 6:35 PM, Bradford Wetmore wrote:
> Ok, David Holmes, I will back out the indention changes.
>
> Thanks, David Katleman, my build just died with the issue you and Tim
> Bell found.
>
> So Windows TL is still broken.  I'll be chasing that next.  Expect
> another review.
>
> Brad
>
>
>
> On 10/16/2013 6:23 PM, David Holmes wrote:
>> On 17/10/2013 11:10 AM, Bradford Wetmore wrote:
>>>
>>> http://cr.openjdk.java.net/~wetmore/8026762/webrev/
>>>
>>> The JDK build broke because the JDK couldn't find the CORBA inbound
>>> files.
>>>
>>> Needs to be quoted due to Windows separator being a semi-colon:
>>>
>>> JAVAC:   is path separator
>>> CYGWIN:  is statement/command separator
>>>
>>> I also did two minor indention cleanups.  I know there are some inbound
>>> CORBA cleanups, is this ok?  Please see the patch file for the complete
>>> list, as "webrev -b" isn't working for whitespace changes.
>>
>> I would leave off the indentation changes given what Erik was trying to
>> achieve.
>>
>> The actual bug fix is fine.
>>
>> Thanks,
>> David
>>
>>> Brad



More information about the build-dev mailing list