RFR: JDK-8025715 Split CompileNativeLibraries.gmk

David DeHaven david.dehaven at oracle.com
Fri Oct 18 05:58:53 UTC 2013


Ah, ok. I'll pull it in from there then. Thanks!

-DrD-

> This is probably due to the fact that I wanted to let mercurial keep track of the origin of the new files, so they were all created by hg cp. Maybe WebRev doesn't handle that situation very well.
> 
> However, this is pushed to the build forest now, so you can extract a proper patch from mercurial instead. 
> 
> /Magnus
> 
> 18 okt 2013 kl. 06:12 skrev David DeHaven <david.dehaven at oracle.com>:
> 
>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8025715
>> 
>> <snip>
>> 
>>> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8025715-split-CompileNativeLibraries/webrev.01
>> 
>> The patch looks backwards... I see a bunch of:
>> --- old/makefiles/CompileNativeLibraries.gmk
>> +++ /dev/null
>> 
>> entries and none of the new filenames. Naturally that doesn't apply at all to the workspace.
>> 
>> The webrev looks ok so far, but I need to apply the patch :)
>> 
>> -DrD-
>> 




More information about the build-dev mailing list