RFR: JDK-8026528: [build] configure does not recognize newer make in cygwin

[Tim Bell]

On 10/18/13 05:30 AM, Magnus Ihse Bursie wrote:
> On 2013-10-18 11:42, Erik Joelsson wrote:
>>
>> On 2013-10-17 21:29, Magnus Ihse Bursie wrote:
>>> On 2013-10-17 17:50, Erik Joelsson wrote:
>>>> Please review this simple patch extending the recognized make 
>>>> versions in configure to 4.0, which was recently released and is 
>>>> already default in Cygwin. I also removed the version check in 
>>>> NewMakefile.gmk since it seems redundant having already done it in 
>>>> configure. They were also not in sync.
>>>
>>> Actually, they are not redundant, and they were added on purpose.
>>>
>>> The problem is that, while configure might find a good make, it is 
>>> not always used to invoke the makefile. A common mistake is e.g. to 
>>> forget to type "gmake" on a solaris system. If gmake is present, 
>>> configure will find it and be happy, but if later on the makefiles 
>>> are executed with another make, things might break (even before we 
>>> get to the part were we start execute recursive makefiles, which is 
>>> done by the make we located in configure).
>>>
>>> So I'd ask you to restore that check and extend it to 4.0 instead.
>>>
>> I thought of this and first concluded that it was unnecessary and 
>> also reacted to the make check not being the same as the configure 
>> check. But now I've thought some more and came up with this. I think 
>> this makes the configure check and the make check accept the same 
>> versions:
>>
>> http://cr.openjdk.java.net/~erikj/8026528/webrev.root.02/
>>
>> It's not pretty but it should accept 3.81, 3.82 and 4.anything.
>
> I'm satisfied, thank you for fixing this! :)
>
> /Magnus

Looks good to me as well.

/Tim