RFR: JDK-8001922, JDK-8001927, JDK-8001921 Improve freetype detection
Tim Bell
tim.bell at oracle.com
Fri Oct 18 19:42:24 UTC 2013
On 10/18/13 06:22 AM, Erik Joelsson wrote:
>
> On 2013-10-18 14:59, Magnus Ihse Bursie wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8001922
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8001927
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8001921
>>
>> These three bugs are all tightly related. The logic for detecting the
>> freetype library has been really messy, and these were three of the
>> ways the deficiencies showed themselves, but they were all resulting
>> from the core problem.
>>
>> I have redesigned the way freetype detection work, to be more in line
>> with the normal way we detect "problematic" stuff in configure, that
>> is, probe in suitable locations with decreasing precision, and check
>> thouroughly what we find. (In this case, by compiling with the header
>> files and linking with the library).
>>
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/JDK-8001922-improve-freetype-detection/webrev.01
>>
>> /Magnus
> Typo: "only one"
> 372 # User specified only on of lib or include. This is an error.
>
> A question on Windows. If we find freetype in $PROGRAMFILES/GnuWin32,
> will the resulting jdk image find the library there at runtime or
> should we still bundle it?
>
> /Erik
Good point - even if it exists on the OpenJDK developer (build) system,
the resulting image could be transplanted elsewhere.
Looks good to me otherwise.
Tim
More information about the build-dev
mailing list