RFR: JDK-8026888: Licensee build failure due to wrong libs being called

[Volker Simonis]

Well, I don't think so. As far as I can see it is used for everything which
is not Windows and not Solaris in Awt2dLibraries.gmk:

+  else ifeq ($(OPENJDK_TARGET_OS), solaris)
     LIBSPLASHSCREEN_CFLAGS += -DWITH_X11 -I$(OPENWIN_HOME)/include
-I$(OPENWIN_HOME)/include/X11/extensions

 else

-    LIBSPLASHSCREEN_CFLAGS

+= -DWITH_WIN32+    LIBSPLASHSCREEN_CFLAGS += -DWITH_X11 $(X_CFLAGS)
-I$(OPENWIN_HOME)/include/X11/extensions

 endif


Or am I missing something?

Volker


On Tuesday, October 22, 2013, Magnus Ihse Bursie wrote:

> OPENWIN_HOME is used only on Solaris, where it is still defined. This
> patch removes it from all other platforms.
>
> /Magnus
>
> 22 okt 2013 kl. 19:04 skrev Volker Simonis <volker.simonis at gmail.com<javascript:;>
> >:
>
> > Hi Erik,
> >
> > I havn't tested this until now, but from a first look it seems a
> > little weird to me that you still use $(OPENWIN_HOME) in
> > Awt2dLibraries.gmk:
> >
> > LIBSPLASHSCREEN_CFLAGS += -DWITH_X11 $(X_CFLAGS)
> > -I$(OPENWIN_HOME)/include/X11/extensions
> >
> > especially after you've removed the logic that probed for it.
> >
> > Regards,
> > Volker
> >
> >
> > On Tue, Oct 22, 2013 at 3:28 PM, Erik Joelsson <erik.joelsson at oracle.com<javascript:;>>
> wrote:
> >> This patch removes the last reference to OPENWIN on linux. All other
> libs
> >> were already converted to using X_LIBS and X_CFLAGS instead of
> OPENWIN_HOME
> >> on linux, but libsplashscreen was still using OPENWIN. I also removed
> the
> >> logic in configure that probed for it.
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8026888
> >>
> >> Webrev: http://cr.openjdk.java.net/~erikj/8026888/webrev.01/
> >>
> >> /Erik
>