RFR 8027059: (sctp) fatal warnings overly restrictive with gcc 4.8.1

Chris Hegarty chris.hegarty at oracle.com
Tue Oct 22 18:44:48 UTC 2013


The SCTP native code complies with -Werror. gcc 4.8.1 reports unused 
parameters as warnings, and this causes the build to fail. gcc 4.8.1 is 
the defaul on Ubuntu 13.10.

These parameters are required as the functions are JNI functions. The 
simplest solution is to ignore/suppress these unused param warnings.

See discussion on:
   http://mail.openjdk.java.net/pipermail/build-dev/2013-July/009513.html

diff --git a/makefiles/lib/NioLibraries.gmk b/makefiles/lib/NioLibraries.gmk
--- a/makefiles/lib/NioLibraries.gmk
+++ b/makefiles/lib/NioLibraries.gmk
@@ -150,7 +150,7 @@

    ifneq ($(OPENJDK_TARGET_OS), macosx)

-    SCTP_WERROR := -Werror
+    SCTP_WERROR := -Werror -Wno-error=unused-parameter
      ifeq ($(OPENJDK_TARGET_CPU_ARCH), ppc)
        SCTP_WERROR :=
      endif

With this change it may be possible to remove the special casing of ppc? 
I would need to check, but this could be handled separately.

-Chris.



More information about the build-dev mailing list