RFR: JDK-8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low

Bradford Wetmore bradford.wetmore at oracle.com
Tue Oct 22 23:10:51 UTC 2013


Looks good to me also.

Brad


On 10/22/2013 3:19 PM, Magnus Ihse Bursie wrote:
> On 2013-10-23 00:14, David Katleman wrote:
>> Please review this simple fix, addressing a problem with yesterday's
>> integration of JDK-8026528.
>>
>> NewMakefile.gmk was extended to recognize version 4 of make, but in
>> the process restricted older usage to exactly 3.81 & 3.82, which means
>> something like 3.82.90 is now flagged as too low.
>>
>> Both my windows builds now successfully pass beyond the
>> NewMakefile.gmk check, running Linux & Solaris builds to confirm there
>> as well.
>>
>> Bug:          https://bugs.openjdk.java.net/browse/JDK-8027068
>> Webrev:   http://cr.openjdk.java.net/~katleman/8027068/webrev
>
> Looks good to me.
>
> /Magnus



More information about the build-dev mailing list