code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

Gerald Thornbrugh gerald.thornbrugh at oracle.com
Wed Oct 23 20:56:41 UTC 2013


Hi Dan,

Thanks for the explanation.

Jerry
> Jerry,
>
> Thanks for the fast review!
>
>
> On 10/23/13 2:41 PM, Gerald Thornbrugh wrote:
>> Hi Dan,
>>
>> Your changes look good but I have a question.
>>
>> On source files that do not have an Oracle copyright like 
>> generated-configure.sh
>> is the correct method to leave the copyright as it is?
>
> generated-configure.sh is a special case relative to the usual (Oracle)
> copyright rules. In particular, this file (should) match the version
> generated if you run 'configure' on the code base. The tools that
> generate the generated-configure.sh file (correctly) do not include an
> Oracle style copyright.
>
> Dan
>
>
>>
>> Thanks!
>>
>> Jerry
>>
>> ----- Original Message -----
>> From: daniel.daugherty at oracle.com
>> To: hotspot-runtime-dev at openjdk.java.net, 
>> serviceability-dev at openjdk.java.net, build-dev at openjdk.java.net
>> Sent: Wednesday, October 23, 2013 2:28:54 PM GMT -07:00 US/Canada 
>> Mountain
>> Subject: code review round 0 for MacOS X FDS whitespace/indent fixes 
>> (8027117)
>>
>> Greetings,
>>
>> I have some MacOS X Full Debug Symbols whitespace/indent fixes.
>> Here is the JDK8/HSX-25 webrev URL:
>>
>> OpenJDK:
>> http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/
>> Internal:
>> http://javaweb.us.oracle.com/~ddaugher/fds_revamp/8027117-webrev/0-jdk8/
>>
>> Because these are whitespace/indent fixes, only the "Cdiffs" and
>> "Udiffs" links show all the changes.
>>
>> This webrev includes changes for the follow repos:
>>
>>       jdk8
>>       jdk8/jdk
>>
>> Gory details are below...
>>
>> As always, comments, questions and suggestions are welcome.
>>
>> Dan
>>
>>
>> The fixes for the following two bugs hit JDK8 at the same time, but
>> came up via different sub-baselines:
>>
>>       7165611 implement Full Debug Symbols on MacOS X hotspot
>>       https://bugs.openjdk.java.net/browse/JDK-7165611
>>
>>       8001931 build-infra: Apply consistent formatting/indentation to
>>               new build-infra files
>>       https://bugs.openjdk.java.net/browse/JDK-8001931
>>
>> During the JDK8 merge process some of the changes from 7165611 were not
>> properly adjusted to meet the new whitespace/indent policy implemented
>> by 8001931. This changeset fixes those style issues.
>>
>> Testing:
>> - JPRT JDK8 forest build and test on all platforms (in process)
>




More information about the build-dev mailing list