Removal of the old build system, partial review

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Oct 31 07:45:36 UTC 2013


On 2013-10-30 16:01, Alan Bateman wrote:
>
> I remember Kelly calling for hazard pay for anyone deleting code and 
> triple pay for anyone deleting Makefile code.
Boy am I going to be rich! :-)

>
> At a high level the plan looks reasonable. Aside from build tools then 
> what else are you expecting to look at in step 2?
There is a wild bunch of assorted left-overs, that are used here and 
there. As you say, most is the build tools, but there is also a lot of 
data files, like input files to the build tools, templates, and stuff 
that perhaps should be in src. Finally, there is a bunch of utilities 
and scripts that are not used by the build system, but seems to be 
designed for the occasional use, like CommentChecker. I don't really 
think these belong in the make directory, but I currently don't have any 
good suggestion of where else to put it either.

> So is the plan to do all of this in jdk8 before RDP2? If so then what 
> would you think about pushing the changes to jdk8/tl rather than 
> jdk8/build? I suggest pushing the changes to jdk8/tl because you are 
> more likely to get more usage and testing before the changes go into 
> jdk8. Also it helps to reduce conflicts (the white-spacing and split 
> out of CompileNativeLibraries.gmk was disruptive).

So, if it is agreed that this should be done in JDK8, that might be a 
good idea. Thank you.

/Magnus



More information about the build-dev mailing list