How to add options to the javac build in the JDK 8 repo?

[Magnus Ihse Bursie]

Hi Joe,

First of all, I think what you're doing is a great job, and I'm all in 
favor of enabling more warnings!

>  DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally 
>
> +JAVAC_WARNINGS:=-Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,try,varargs 
> -Werror

Would you mind elaborating a bit on the choice to remove the "all" and 
replace it with a specified list of warnings? From my point of view, 
having "all" turned on, and specific warnings turned off seems like an 
approach that minimizes the risk that someone inadvertently adds code 
that will cause an warning of a type that is currently not specifically 
listed.

If having "all" turned on results in warnings that breaks the build due 
to -Werror, these warnings should be explicitely disabled in the Xlint 
options as well.

Is it the case that Xlint:all is a misnomer, just like the GCC -Wall, 
which does in fact not at all turn on all warnings? According to the 
documentation, Xlint:all turns on all "recommended" warnings, but I 
can't find any specification of what those "recommended" warnings are. 
But even if this is the case, it would not hurt to keep the "all" and 
add the additional warnings that we want enabled, would it?

/Magnus