RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

[Staffan Larsen]

In SunCommandLineLauncher.java:

 198             if (home.length() > 0) {
 199                 String os_arch = System.getProperty("os.arch");
 200                 if ("SunOS".equals(System.getProperty("os.name"))) {
 201                     exePath = home + File.separator + "bin" + File.separator + exe;
 202                 }
 203             } else {
 204                 exePath = exe;
 205             }

I think this should be:

 198             if (home.length() > 0) {
 201                 exePath = home + File.separator + "bin" + File.separator + exe;
 203             } else {
 204                 exePath = exe;
 205             }


Thanks,
/Staffan


On 9 sep 2013, at 18:12, Kumar Srinivasan <kumar.x.srinivasan at oracle.com> wrote:

> Hi David,
> 
>> Hi Kumar,
>> 
>> This is still dead code in src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
>> 
>> String os_arch = System.getProperty("os.arch");
> 
> Ah, I will take care of it. Thanks for spotting this.
>> 
>> Also:
>> 
>> test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so 
>> 
>> I know this already exist but I thought binaries were disallowed in the open repo?
> 
> Alan, are the nio changes acceptable? Let me know if you need more time to go over all
> the changes.
> 
> Kumar
> 
>> 
>> Davud
>> 
>> On 9/09/2013 1:09 PM, Kumar Srinivasan wrote:
>>> Hi David, Staffan, Alan,
>>> 
>>> I have addressed all the issues pointed and some more I found while jprt
>>> testing.
>>> 
>>> The updated webrev for jdk is here:
>>> http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.1/
>>> 
>>> and the delta webrev since the last review webrev is here:
>>> http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.1/webrev.delta/index.html 
>>> 
>>> 
>>> Thanks
>>> Kumar
>>> 
>>> 
>>>> Hi Kumar,
>>>> 
>>>> A few minor comments ...
>>>> 
>>>> src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
>>>> 
>>>> Seems to me this is all dead now:
>>>> 
>>>> 199                 /*
>>>> 200                  * A wrinkle in the environment:
>>>> 201                  * 64-bit executables are stored under
>>>> $JAVA_HOME/bin/os_arch
>>>> 202                  * 32-bit executables are stored under
>>>> $JAVA_HOME/bin
>>>> 203                  */
>>>> 204                 String os_arch = System.getProperty("os.arch");
>>>> 
>>>> os_arch is no longer used and the comment no longer applicable.
>>>> 
>>>> ---
>>>> 
>>>> src/solaris/bin/java_md_solinux.c
>>>> 
>>>> This seems to force DUAL_MODE off regardless of what the user may set
>>>> it to:
>>>> 
>>>>  #ifdef __solaris__
>>>> ! #  ifdef DUAL_MODE
>>>> ! #    undef DUAL_MODE
>>>> ! #  endif
>>>> 
>>>> why doesn't it just not define DUAL_MODE?
>>>> 
>>>> ---
>>>> 
>>>> test/demo/jvmti/DemoRun.java
>>>> test/sun/tools/jhat/HatRun.java
>>>> 
>>>> It isn't clear to me why you need to retain the d64 variable at all.
>>>> 
>>>> ---
>>>> 
>>>> test/tools/launcher/ExecutionEnvironment.java
>>>> 
>>>> typo: appopriate
>>>> 
>>>> 
>>>> Thanks,
>>>> David
>>>> ----
>>>> 
>>>> 
>>>> 
>>>> On 7/09/2013 2:47 AM, Kumar Srinivasan wrote:
>>>>> Hello,
>>>>> 
>>>>> Please review the changes to remove Solaris 32-bit binaries from JDK8
>>>>> distros,
>>>>> at this time the dual mode support in the launcher is being disabled.
>>>>> 
>>>>> Message regarding this:
>>>>> http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003159.html 
>>>>> 
>>>>> 
>>>>> The jdk changes are here:
>>>>> http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.0/
>>>>> 
>>>>> The top forest changes are here:
>>>>> http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.0/
>>>>> 
>>>>> 
>>>>> Thanks
>>>>> Kumar
>>>>> 
>>>>> 
>>> 
>