RFR(M): 8024265: Enable new build on AIX (jdk part)

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Sep 18 10:14:46 UTC 2013


On 2013-09-16 17:20, Volker Simonis wrote:
> Hi,
>
> could you please review the following webrev which contains the changes
> needed in the 'jdk' repository in order to build the OpenJDK on AIX:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8024265_jdk/

All in all, it looks good!

My only nitpick is that there's a copy/paste error in 
CompileNativeLibraries.gmk, where the comment does not match the actual 
if condition:

2866 ifeq ($(OPENJDK_TARGET_OS), aix)
2867         LIBJSOUND_CFLAGS += -DX_PLATFORM=X_AIX
2868 endif # OPENJDK_TARGET_OS linux

I don't think this warrants a new review, but if you get the chance you 
might want to fix it.

/Magnus



More information about the build-dev mailing list