[SPAM]Re: JDK-7082220 : Visual Studio projects broken after change: backport to OpenJDK7/hotspot

[Seán Coffey]

Thanks for the updates Francis. Good to hear you solved the issue.

> I don't know about JPRT and googled for it but did found anything 
> relevant; Where is located JPRT?

JPRT is a build/test system used by Oracle. It's referenced every so 
often on OpenJDK mail threads :
https://weblogs.java.net/blog/kellyohair/archive/2006/09/jprt_buildtest.html

regards,
Sean.

On 24/09/2013 06:30, Francis ANDRE wrote:
> Sean
>
> OK, I found the problem: I had in the Windows environement variables a 
> variable named OpenJDK, which under nmake/make gets translated into 
> OPENJDK under cygwin, but echo $OpenJDK prints the value while echo 
> $OPENJDK prints nothing!
>
> Sorry for the noise and thanks for your attention on my problem.... 
> May be it would be interesting to add a check on the value of OPENJDK 
> somewhere to avoid such mistake.
>
> Francis
>
> Le 23/09/2013 19:46, Seán Coffey a écrit :
>> I don't see the failure either. Ran an OpenJDK test job through 
>> JPRT.  I wonder if make version and/or shell env could have an impact 
>> ? Can you share more details Francis ?
>>
>> I see an OPENJDK condition expression in trace.make and wonder if 
>> that's being parsed incorrectly for this issue ?
>>
>> http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/file/tip/make/windows/makefiles/trace.make
>>
>> regards,
>> Sean.
>>
>> On 23/09/13 17:54, Erik Joelsson wrote:
>>> It's certainly not supposed to fail like that. I'm not able to 
>>> reproduce this problem cloning from 
>>> http://hg.openjdk.java.net/jdk7u/jdk7u-dev. From where did you get 
>>> your sources?
>>>
>>> /Erik
>>>
>>> On 2013-09-23 17:51, Francis ANDRE wrote:
>>>> Sean
>>>>
>>>> The point is that OpenJDK7u is not open source while OpenJDK7 is... 
>>>> Following is a snippet of the make log joined...
>>>> That's the same story for the HSX project. Thus either the 
>>>> OpenJDK7u is an open source project and then the makefiles are 
>>>> wrong, either it is not and then I need the backport on the 
>>>> OpenJDK7 project.
>>>>
>>>> Regards
>>>>
>>>> Francis
>>>>
>>>>
>>>>         mv  ad_x86_32.cpp  ad_x86_32.hpp ad_x86_32_clone.cpp 
>>>> ad_x86_32_expand.cpp  ad_x86_32_forma
>>>> t.cpp  ad_x86_32_gen.cpp  ad_x86_32_misc.cpp 
>>>> ad_x86_32_peephole.cpp  ad_x86_32_pipeline.cpp  adGlob
>>>> als_x86_32.hpp  dfa_x86_32.cpp adfiles/
>>>>         "C:\Progra~1\Java\jdk1.6.0_35\bin\javac" -g -encoding ascii 
>>>> -source 6 -target 6 -d jvmtifile
>>>> s Z:\DEV\OpenJDK7u\hotspot/src/share/vm/prims/jvmtiGen.java
>>>> Generating jvmtifiles/jvmtiEnv.hpp
>>>> Generating jvmtifiles/jvmtiEnter.cpp
>>>> Generating jvmtifiles/jvmtiEnterTrace.cpp
>>>> Generating jvmtifiles/jvmtiEnvRecommended.cpp
>>>> Generating jvmtifiles/bytecodeInterpreterWithChecks.cpp
>>>> Generating jvmtifiles/jvmti.h
>>>> *NMAKE : fatal error U1073: incapable d'obtenir 
>>>> 'Z:\DEV\OpenJDK7u\hotspot/src/closed/share/vm/trace/t**
>>>> **raceEventClasses.xsl'*
>>>> Stop.
>>>> NMAKE : fatal error U1077: 'cd' : code retour '0x2'
>>>> Stop.
>>>> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual 
>>>> Studio 10.0\VC\BIN\nmake.EXE"' : code
>>>>  retour '0x2'
>>>> Stop.
>>>> Makefile:191: recipe for target `generic_build2' failed
>>>> make[1]: *** [generic_build2] Error 2
>>>> make[1] : on quitte le répertoire « 
>>>> /cygdrive/z/DEV/OpenJDK7u/hotspot/make »
>>>> Makefile:151: recipe for target `jvmg' failed
>>>> make: *** [jvmg] Error 2
>>>>
>>>> FrancisANDRE at idefix /cygdrive/z/DEV/OpenJDK7u/hotspot/make
>>>> Le 22/09/2013 20:40, Seán Coffey a écrit :
>>>>> Francis,
>>>>>
>>>>> the OpenJDK 7 repository corresponds to the JDK 7 GA release made 
>>>>> a few years ago. The OpenJDK 7u repository is used to gather fixes 
>>>>> for the JDK 7 update releases.
>>>>>
>>>>> Isn't this patch already in the updates ? (7u2)
>>>>>
>>>>> http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/2f27ed2a98fa
>>>>> https://bugs.openjdk.java.net/browse/JDK-2213981
>>>>>
>>>>> regards,
>>>>> Sean.
>>>>>
>>>>> On 22/09/2013 09:37, Francis ANDRE wrote:
>>>>>> HI
>>>>>>
>>>>>> the patch "JDK-7082220 : Visual Studio projects broken after 
>>>>>> change 7016797: Hotspot: securely/restrictive load dlls"  is 
>>>>>> missing in the 
>>>>>> OpenJDK7/hotspot/src/share/tools/ProjectCreator/WinGammaPlatformVC10.java. 
>>>>>> I applied it localy but some other OpenJDK developpers on 
>>>>>> WXP/VS2010 would benefit of this patch if it was applied to the 
>>>>>> OpenJDK7 forest. So I am wondering how to request a backport of 
>>>>>> this patch to the OpenJDK7/hotspot repository?
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>> FA
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>