JDK-8036003: Add variable not to separate debug information.

[David Holmes]

On 5/04/2014 12:55 AM, Yasumasa Suenaga wrote:
> Hi all,
>
>> This should fix it:
>> http://pkgs.fedoraproject.org/cgit/java-1.8.0-openjdk.git/commit/?id=1734315551d634b7467f28788d90595b467ea5eb
>>
>
> I updated OpenJDK8 to java-1.8.0-openjdk-1.8.0.0-0.34.b132.fc20 .
> However, debuginfo files are not contained ELF sections for debugging.
> (I checked libjvm.so.debug and libnio.so.debug with "readelf -S")
>
> According to SPEC file of OpenJDK8, following options are passed to "make":
> -----------------
> make \
>      SCTP_WERROR= \
>      DEBUG_BINARIES=true \
>      FULL_DEBUG_SYMBOLS=0 \
>      STRIP_POLICY=none \
>      ALT_OBJCOPY=/does_not_exist \
>      LOG=trace \
>      all
> -----------------
>
> I ran "grep" with DEBUG_BINARIES in jdk makefiles, however I could not
> find it.
> At least, DEBUG_BINARIES does not affect to jdk sources, and also does not
> affect to hotspot sources.

DEBUG_BINARIES is used in the hotspot makefiles.

./linux/makefiles/gcc.make

ifeq ($(DEBUG_BINARIES), true)
   CFLAGS += -g
else

David
-----

>
> I've succeeded to make binaries which are contained debuginfo as following:
>
> http://mail.openjdk.java.net/pipermail/build-dev/2014-March/012037.html
> $ make images STRIP_POLICY=no_strip POST_STRIP_CMD=""
>
>
> I guess that we should run "make" above options to avoid this issue in
> currently.
>
>
> Thanks,
>
> Yasumasa
>
>
> On 03/04/2014 04:01 AM, Omair Majid wrote:
>> * Andrew Haley <aph at redhat.com> [2014-03-03 04:43]:
>>> On 02/28/2014 09:18 AM, Yasumasa Suenaga wrote:
>>>> For example, OpenJDK8 in Fedora20 ships libjvm.so and
>>>> libjvm.debuginfo .
>>>> libjvm.debuginfo is generated in OpenJDK's makefiles, however it
>>>> does not
>>>> contain debug information. Actual debug information is shipped by
>>>> OpenJDK
>>>> debuginfo package.
>>> That's a bug in Fedora's build.  We should fix it.
>> This should fix it:
>> http://pkgs.fedoraproject.org/cgit/java-1.8.0-openjdk.git/commit/?id=1734315551d634b7467f28788d90595b467ea5eb
>>
>>
>> Thanks,
>> Omair
>>
>