RFR: 8040332 : (s/URGENT) fixpath must quote empty arguments

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Apr 16 07:24:17 UTC 2014


Fix looks good to me.

Noticed this:
> while ((blocklen = fread(block,1,sizeof(block),atin)) > 0) {
Maybe add some space after the commas, if you are fixing other formatting issues?

/Magnus

> On 15 apr 2014, at 22:30, Mike Duigou <mike.duigou at oracle.com> wrote:
> 
> [fix missing title]
> 
>> On Apr 15 2014, at 13:30 , Mike Duigou <mike.duigou at oracle.com> wrote:
>> 
>> Hello all;
>> 
>> The recent change to fixpath in JDK-8039411 (https://bugs.openjdk.java.net/browse/JDK-8039411) (http://hg.openjdk.java.net/jdk9/dev/rev/45183b39d300) introduced a regression for zero length arguments.
>> 
>> This changes forces quoting of zero length arguments. It also contains fixes to a spelling error and cleans up some inconsistent formatting.
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8040332
>> http://cr.openjdk.java.net/~mduigou/JDK-8040332/0/webrev/
>> 
>> Mike
> 



More information about the build-dev mailing list