RFR: 8040332 : (s/URGENT) fixpath must quote empty arguments

Mike Duigou mike.duigou at oracle.com
Thu Apr 17 20:54:47 UTC 2014


On Apr 17 2014, at 03:20 , Dave Pointon <dpointo8 at linux.vnet.ibm.com> wrote:

> On Tue, 2014-04-15 at 13:30 -0700, Mike Duigou wrote:
>> [fix missing title]
>> 
>> On Apr 15 2014, at 13:30 , Mike Duigou <mike.duigou at oracle.com> wrote:
>> 
>>> Hello all;
>>> 
>>> The recent change to fixpath in JDK-8039411 (https://bugs.openjdk.java.net/browse/JDK-8039411) (http://hg.openjdk.java.net/jdk9/dev/rev/45183b39d300) introduced a regression for zero length arguments.
>>> 
>>> This changes forces quoting of zero length arguments. It also contains fixes to a spelling error and cleans up some inconsistent formatting.
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8040332
>>> http://cr.openjdk.java.net/~mduigou/JDK-8040332/0/webrev/
>>> 
>>> Mike
>> 
> 
> Hi Mike ,
> 
> Looks good to me but I wonder if webrev has a benign defect in as much
> as lines are shown to be different that would, outwardly, otherwise
> appear to be unchanged.

By line count the majority of the changes in this patch are whitespace changes and generate non-obvious diffs.

> 
> (Let's see if this makes it into the group mail;-)

Yep!

Mike


More information about the build-dev mailing list