RFR: 8041267 : (s) Add filtering capability to CacheFind

Mike Duigou mike.duigou at oracle.com
Tue Apr 22 18:42:08 UTC 2014


On Apr 22 2014, at 01:21 , Erik Joelsson <erik.joelsson at oracle.com> wrote:

> Hello Mike,
> 
> This will probably work fine. Perhaps a note on the formatting of the new argument is needed? From what I can tell it needs to always start with "-a".

The specialization could theoretically start with an -o but you are right that for openJDK builds it will probably always be "-a". I added a note and fixed one additional spelling error (FIND_CACHE_DIR vs FIND_CACHE_DIRS)

Mike

> I can't help but think that there might be a need for named caches at some point if this is introduced, but I will add that if I find a need for it.
> 
> /Erik
> 
> On 2014-04-19 20:54, Mike Duigou wrote:
>> Hello all;
>> 
>> In some cases the results of find operations need to be more specific. Adding a filter capability to the find/caching stage would reduce the overhead of some requests. This changeset adds an optional second parameter allowing a find expression to provide additional filtering of find results.
>> 
>> JBSBUG: https://bugs.openjdk.java.net/browse/JDK-8041267
>> WEBREV: http://cr.openjdk.java.net/~mduigou/JDK-8041267/0/webrev/
>> 
>> Once the functionality is available it will be used in CreateJars.gmk, GensrcProperties.gmk, and Images.gmk to narrow find results.
>> 
>> Mike
> 




More information about the build-dev mailing list