RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

Erik Joelsson erik.joelsson at oracle.com
Mon Apr 28 13:12:59 UTC 2014


Hello Ivan,

The change looks good to me, but I'm not a reviewer for 7u.

/Erik

On 2014-04-28 14:45, Ivan Gerasimov wrote:
> Ping.
>
> Could someone please help review this quite simple fix?
>
> I've tested the change with JPTR in three configuration: open jdk, 
> full jdk and licensee source.
> The binaries were successfully built in all three configurations.
> The change did not make any difference to open and full jdk.
> For the licensee bundle, the kerberoes tools for windows are now created.
>
> Any comments/suggestions?
>
> Sincerely yours,
> Ivan
>
>
> On 21.04.2014 22:43, Ivan Gerasimov wrote:
>> Hello!
>>
>> This is a 7u only issue.
>>
>> I was reported that kerberos tools aren't built from the licensee 
>> source bundle.
>> The cause is that building of the launchers is started from the 
>> 'build' target in the Makefile.
>> On Windows, the 'build' target is only defined, if 
>> ./common/Library.gmk is included, and this is included when 
>> ./jdk/windows/native/sun/security/krb5 directory exists.
>> This is not the case for the licensee source bundle.
>>
>> It appears to be enough to replace the 'build' target with 'all':
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8038961
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8038961/0/webrev/
>>
>> Sincerely yours,
>> Ivan
>>
>>
>




More information about the build-dev mailing list