RFR: JDK-8055188: General cleanup of minor issues from source restructure

Erik Joelsson erik.joelsson at oracle.com
Wed Aug 20 14:50:12 UTC 2014


On 2014-08-20 16:48, Tim Bell wrote:
> Hi Erik:
>
>> Please review this little collection of fixes for minor issues left 
>> over from the source code restructure push. These are mostly based on 
>> the comments provided by Magnus in that review.
>>
>> Webrevs: http://cr.openjdk.java.net/~erikj/8055188/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055188
>>
>> The things fixed in this patch are:
>>
>> * Moved jdk/make/bundle to jdk/make/data/bundle
>>
>> * Removed leftover $(if $(SHUFFLED)... in GensrcSwing.gmk
>>
>> * Removed no longer needed EXTRA_FILE in CreateJars.gmk
>>
>> * Renamed SetupJava.gmk to SetupJavaCompilers.gmk
>>
>> * Removed no longer used CopyIntoClasses.gmk
>>
>> * Added a comment about fdlibm not being a part of the product directly
>>
>> * Renamed LIBDIR, INCLUDEDIR and OPENJDK_TARGET_OS_INCLUDE to 
>> LIB_DST_DIR, INCLUDE_DST_DIR and INCLUDE_DST_OS_DIR in Copy*.gmk.
>>
>> * Moved closed only native library definitions to closed makefiles.
>>
>> * Fixed linker warnings on macosx for demos by adding a dependency 
>> forcing demos to be built after hotspot and java.base-libs.
>>
>> * Fixed dependencies for main-jars from JDK-8055497.
>
> webrev does not show the changes (if there are any... 3 lines?) to 
> make/gendata/Gendata-java.base.gmk
>
Ah, I removed three trailing spaces in that file.
> Otherwise looks good to me.
>
Thanks!

/Erik
> Tim
>
>




More information about the build-dev mailing list