RFR: JDK-8055096: Remove explicit mx flag from javadoc command line

Mike Duigou mike.duigou at oracle.com
Thu Aug 21 17:21:42 UTC 2014


Looks good.

Do we know if the headless=true is actually needed?

Mike

On Aug 21 2014, at 10:16 , Tim Bell <tim.bell at oracle.com> wrote:

> Hi Erik:
> 
>> Please review this small patch. In Javadoc.gmk the javadoc command is defined with an explicit mx flag. However, configure is already calculating a suitable mx for a "large" java process, which is already provided in the JAVA variable. This patch removes the redundant mx flag from Javadoc.gmk.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055096
>> Patch inline:
>> 
>> diff -r dbb964d72f25 make/Javadoc.gmk
>> --- a/make/Javadoc.gmk
>> +++ b/make/Javadoc.gmk
>> @@ -52,7 +52,6 @@
>> BUILD_NUMBER=$(JDK_BUILD_NUMBER)
>> 
>> JAVADOC_CMD = $(JAVA) \
>> -    -Xmx1024m \
>>     -Djava.awt.headless=true \
>>     $(NEW_JAVADOC) \
>>     -bootclasspath $(JDK_OUTPUTDIR)/classes
> 
> Looks good.  Approved.
> 
> Tim
> 




More information about the build-dev mailing list