RFR: JDK-8065576: Enable pipefail in the shell used by make to better detect build errors

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Dec 5 14:47:01 UTC 2014


On 2014-12-01 14:27, Erik Joelsson wrote:
> Hello,
>
> New webrev, which addresses Magnus' concern below, and various fixes 
> in Hotspot for incompatibilities with errexit.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8065576/webrev.02/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8065576
>
> For the LOG=trace issue Magnus described below, it was enough to just 
> replace $$(BASH) with $$(SHELL) and things worked as expected for me.

I'm a bit surprised at this. Did the options really fall through into 
the actual shell executing in the wrapper?

But if you say it reall works, I'm fine with it. The rest of the code 
looks good.

/Magnus




More information about the build-dev mailing list