RFR: JDK-8066761: Investigate -sourcepath usage when compiling java
Jonathan Gibbons
jonathan.gibbons at oracle.com
Mon Dec 8 17:42:12 UTC 2014
On 12/08/2014 06:53 AM, Magnus Ihse Bursie wrote:
> On 2014-12-08 13:09, Erik Joelsson wrote:
>> Hello,
>>
>> Please review this fix, removing the use of -sourcepath when
>> compiling java sources. For a long time, all java compilation lines
>> have included a -sourcepath <srcdir> parameter. We have now concluded
>> that in some cases it's just wrong and the rest of the cases it's
>> just unnecessary.
>>
>> I have tried building with and without this patch and enabling
>> sjavac, and the class file output is equivalent in all cases.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8066761
>> Webrev: http://cr.openjdk.java.net/~erikj/8066761/webrev.01/
>
> Looks good to me. Good riddance!
>
> /Magnus
It is possible that -sourcepath is a hangover from the recusive-make
days, when we built JDK package-by-package.
-- Jon
More information about the build-dev
mailing list