RFR(S): 8067330 : ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

Severin Gehwolf sgehwolf at redhat.com
Fri Dec 12 15:08:55 UTC 2014


On Fri, 2014-12-12 at 06:41 -0800, Tim Bell wrote:
> Thanks, Erik
> 
> The change looks good to me as well.
> 
> Tim

Thanks, all!

Cheers,
Severin

> On 12/12/14 06:31, Erik Joelsson wrote:
> > I can push it.
> >
> > /Erik
> >
> > On 2014-12-12 15:12, Volker Simonis wrote:
> >> Hi Severin,
> >>
> >> the change looks good to me and it only affects the ZERO build so
> >> there's no risk to influene any other platform.
> >>
> >> Unfortunately I can not push it because it requires the regeneration
> >> of 'common/autoconf/generated-configure.sh'. So you still need a
> >> sponsor from within Oracle.
> >>
> >> Regards,
> >> Volker
> >>
> >>
> >> On Fri, Dec 12, 2014 at 2:18 PM, Severin Gehwolf 
> >> <sgehwolf at redhat.com> wrote:
> >>> Hi,
> >>>
> >>> Could someone please review and sponsor this fix for JDK-8067330? In
> >>> particular, the hotspot build expects either PPC64 or PPC32 to be
> >>> defined (hotspot/src/share/vm/utilities/macros.hpp:366) and if one of
> >>> them is indeed defined PPC gets defined as well. However if neither of
> >>> the two is defined then PPC gets silently undefined. This may result in
> >>> incorrectly generated code for the Zero variant build.
> >>>
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8067330
> >>> webrev:
> >>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8067330/webrev.01/
> >>>
> >>> Thanks!
> >>>
> >>> Cheers,
> >>> Severin
> >>>
> >
> 






More information about the build-dev mailing list