RFR: JDK-8065673: Makefile enable JAXP tests running

Tristan Yan tristan.yan at oracle.com
Fri Dec 12 18:10:13 UTC 2014


Thanks Joe answering this.
Updated webrev by changing jaxp_test to jaxp_all, Also correct “Jaxp" as “JAXP”.

http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.01/ <http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.01/>
http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.02/ <http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.02/>

Tristan

> On Dec 12, 2014, at 9:45 AM, huizhe wang <huizhe.wang at oracle.com> wrote:
> 
> 
> On 12/12/2014 2:45 AM, Alan Bateman wrote:
>> On 11/12/2014 21:10, Tristan Yan wrote:
>>> Thanks Alan and Joe
>>> I added jaxp testset, now jaxp_tests is under jaxp testset only. Also I have added jaxp testset to pit.
>>> 
>>> http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.01/ <http://cr.openjdk.java.net/%7Etyan/JDK-8065673/webrev.01/>
>>> http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.00/ <http://cr.openjdk.java.net/%7Etyan/JDK-8065673/jaxp/webrev.00/>
>>> 
>>> Thanks
>>> 
>> I think this looks much better. A suggestion for the test group name is "jaxp_all" rather than "jaxp_test". A minor comment on jprt.properties is that the comments should probably use "JAXP" rather than "Jaxp".
>> 
>> A side question: Are there plans to move the JAXP tests from the jdk/test directory to the jaxp repo so that they can be with their friends? I think that would make this new testset more useful.
> 
> Yes, it's in our plan to move jaxp tests from jdk/test to jaxp/test.
> 
> -Joe
> 
>> 
>> -Alan.
>> 
> 




More information about the build-dev mailing list