Review request: JDK-8067360: verify-modules target was dropped in jdk9 b41

Mandy Chung mandy.chung at oracle.com
Mon Dec 15 18:38:44 UTC 2014


Thanks for the review.  I don't mind filing a bug for javadoc change and 
it's easy as it's a separate issue and cleaner to separate them.   I'm 
happy this saves me the hassle of a separate review, thanks!

Mandy

On 12/15/14 12:56 AM, Erik Joelsson wrote:
> Looks good to me. I don't mind if you fix javadoc in the same change. 
> It's such a small issue I rather not go through the hassle of creating 
> a bug and a new review.
>
> Thanks!
> /Erik
>
> On 2014-12-12 19:25, Mandy Chung wrote:
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8067360/webrev.00/
>>
>> This patch adds back the verify-modules target to the dependences of 
>> the images target that got dropped in the merge and hides a bug in 
>> jdeps -Xverify:access.
>>
>> Erik - I notice make/Javadoc.gmk that sets -bootclasspath 
>> $(JDK_OUTPUTDIR)/classes that does not exist.  I include a patch to 
>> make/Javadoc.gmk in the webrev.  Do you prefer to separate it and 
>> file a new bug for it?
>>
>> Mandy
>>
>>
>




More information about the build-dev mailing list