RR(S) 8030941: Darwin mapfile-vers doesn't work for other BSD

Dmitry Samersoff dmitry.samersoff at oracle.com
Tue Jan 7 07:55:41 UTC 2014


David,

Thank you!

-Dmitry

On 2014-01-07 09:28, David Holmes wrote:
> Hi Dmitry,
> 
> I didn't see any reviews of this ...
> 
> On 22/12/2013 2:34 AM, Dmitry Samersoff wrote:
>> Hi Everybody,
>>
>> I'd debug out last blocker for clear build of hotspot on FreeBSD.
>>
>> Darwin's mapfile-vers couldn't be used for FreeBSD (and probably other
>> BSDs) so changed makefiles to use generic one if we are not on Darwin.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8030941/webrev.01/
> 
> Seems okay to me.
> 
> 
>> PS:
>>
>> As mapfile-vers is essentially the same for all platforms except Darwin
>> it might make sense to create a separate directory and put it to a
>> single place.
> 
> There have been some differences between platforms in the past but we
> may have cleaned all of those up now. Darwin/osx was the only build that
> complained about non-existent symbols listed in the map file.
> 
> David


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.



More information about the build-dev mailing list