RFR: JDK-8029512 : webrev.ksh: fix parsing of parent repo paths from hgrc file

Dave Pointon dpointo8 at linux.vnet.ibm.com
Wed Jan 8 11:36:53 UTC 2014


Hiya Mike ,

On Tue, 2014-01-07 at 09:35 -0800, Mike Duigou wrote:
> On Jan 7 2014, at 03:46 , Dave Pointon <dpointo8 at linux.vnet.ibm.com> wrote:
> 
<snip>
> 
> Thanks for the correction. My tests didn't require the filter stage so I failed to notice that this typo had crept in.
> 

No probs - that's what reviews are all about.

> > 
> > I would suggest the use of perl for JDK 9 since all whitespace
> > characters are matched &/or captured by the '\s' regex operator.
> 
> The hope is that webrev will be retired within the next year. The current efforts are intended only as a stopgap until the "glorious future" arrives.
> 

A very highly laudable aim ... here's to the future :-)

<snip>

Best rgds ,

-- 
Dave Pointon FIAP MBCS

Now I saw, tho' too late, the folly of beginning a work before we count
the cost and before we we judge rightly of our strength to go thro'
with it - Robinson Crusoe




More information about the build-dev mailing list