Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

Erik Joelsson erik.joelsson at oracle.com
Thu Jan 9 08:47:23 UTC 2014


On 2014-01-09 09:34, Alan Bateman wrote:
> On 09/01/2014 08:07, Anthony Scarpino wrote:
>> Hi,
>>
>> I have a change that needs a review to the manifest.mf file for the 
>> Specification-Version from 1.8 to 1.9.  This is needed as part of the 
>> build & signing of crypto signed jar files. Being from the security 
>> side and not the build side of the openjdk world, if there is a 
>> better way to address this, please let me know.
>>
>> http://cr.openjdk.java.net/~ascarpino/8031372/webrev.00/
> This looks right to me.
>
> As an aside, I think we should strike while the iron is hot and get 
> the changes required to move major versions written down somewhere 
> (maybe checked into the forest). I see Joe has updated the 
> JDK_MINOR_VERSION, there was change required to jtreg, and probably a 
> few other changes that. Having these tasks captured somewhere might 
> make it easier the next time.
>
The patch looks good to me.

For the future, is there a reason for not automatically generating the 
"specification-version" based on the version numbers we have, or at 
least move the definition of it to the version numbers file?

/Erik




More information about the build-dev mailing list