RFR: JDK-8030946, JDK-8031300: No jdeps.1 and jjs.1 man pages in jdk8 b122 build and jvisualvm.1 and jcmd.1 missing on macosx

Tim Bell tim.bell at oracle.com
Thu Jan 9 15:19:50 UTC 2014


Hi Erik

On 01/ 9/14 04:23 AM, Magnus Ihse Bursie wrote:
> On 2014-01-09 12:20, Erik Joelsson wrote:
>> Hello,
>>
>> Please review the open part of this change for jdk8.
>>
>> New man pages have been added in jdk8, but the makefiles were never 
>> updated to include these man pages in the build. There are two 
>> separate bugs covering this:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8031300
>> https://bugs.openjdk.java.net/browse/JDK-8030946
>>
>> This change adds the new man pages to Images.gmk. It also adds new 
>> (empty) Japanese translations for the new pages for Macosx. We 
>> apparently do not have real translations for Macosx, but all the old 
>> man pages have empty dummys, and the build would fail without them. I 
>> also identified three such old dummy pages that aren't needed (and 
>> only existed for ja on macosx), klist, ktab and kinit, and removed them.
>>
>> http://cr.openjdk.java.net/~erikj/8031300/webrev.jdk.01/
>>
>> /Erik
>
> Looks good to me.
>
> /Magnus

Looks good to me as well.

Tim




More information about the build-dev mailing list