RFR: 8030350 : (s) Enable additional compiler warnings for GCC

[Mike Duigou]

On Jan 9 2014, at 04:30 , Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:

> On 2014-01-08 22:11, Mike Duigou wrote:
>> You are correct. Sorry (wrong -r option and use of a file list misled me into thinking it was generating the right content).
>> 
>> I have added
>> 
>>  http://cr.openjdk.java.net/~mduigou/JDK-8030350/3/webrev/
>> 
>> and checked to make sure it has the right content.
> 
> Thanks!
> 
> A question regarding the changes in toolchain.m4:
> 
>> +      CCXXFLAGS_JDK="$CCXXFLAGS $CCXXFLAGS_JDK -Wall -Wextra -Wformat=2 -Wno-unused-parameter -Wno-unused -Wno-parentheses \
> 
> Isn't -Wno-unused-parameter redundant if you have -Wno-unused? I have not tested compiling code provoking that warning, but my understanding from reading http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html is that -Wno-unused will turn off all "unused" warnings. While unused-parameter is usually only just annoying, some of the other are more intelligent and useful, and could just as well be turned on -- but I understand if that is not part of your current fix.

For unknown reasons both seemed to be required. I am not sure why. Despite the -Wno-unused I still see many unused local warnings.

Mike