RFR: 8031669: (xs) Allow override of "simple required tools" in basics.m4

[Magnus Ihse Bursie]

On 2014-01-14 02:57, Mike Duigou wrote:
> Hello all;
>
> This changeset allows overriding of the "simple required tools" which are gathered in BASIC_SETUP_FUNDAMENTAL_TOOLS macro of basics.m4 I didn't extend the override ability to every tool, instead primarily to the file manipulation and archiving tools which I need to override for a project I am working on.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8031669/0/webrev/
>
> Mike

I think you are partly reimplementing functionality that already exists.

If you call AC_PATH_PROG(CAT, cat) and $CAT is already definied, then it 
will not change it. So if you call configure like this
configure CAT=/usr/local/bin/meow
then AC_PATH_PROG will not look for "cat", but will accept that CAT is 
set to /usr/local/bin/meow.

I think this is your needed use case..?

On the other hand, you do actually need AC_PATH_PROGS to check for both 
readlink and greadlink. And we should have used it to test for both 
gdiff and diff. So BASIC_REQUIRE_PROGS seems to fill a purpose anyway. 
But I think it is overkill to have both BASIC_REQUIRE_PROG and 
BASIC_REQUIRE_PROGS; I think you can just convert the former into the 
latter and use it everywhere.

/Magnus