RFR: JDK-8031709: Configure --with-jvm-variants=client, server, x produces default outputdir containing comma
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Tue Jan 14 15:03:31 UTC 2014
Looks good to me.
/Magnus
> On 14 jan 2014, at 15:08, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>
> Running configure with more than 2 jvm variants causes the default outputdir to contain a comma, which in turn breaks the build in corba. The fix is simple and posted inline:
>
> diff -r d33e5e1a26e2 common/autoconf/jdk-options.m4
> --- a/common/autoconf/jdk-options.m4
> +++ b/common/autoconf/jdk-options.m4
> @@ -105,7 +105,7 @@
> fi
>
> # Replace the commas with AND for use in the build directory name.
> - ANDED_JVM_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/^,//' -e 's/,$//' -e 's/,/AND/'`
> + ANDED_JVM_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/^,//' -e 's/,$//' -e 's/,/AND/g'`
> COUNT_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/server,/1/' -e 's/client,/1/' -e 's/minimal1,/1/' -e 's/kernel,/1/' -e 's/zero,/1/' -e 's/zeroshark,/1/'`
> if test "x$COUNT_VARIANTS" != "x,1"; then
> BUILDING_MULTIPLE_JVM_VARIANTS=yes
>
>
> /Erik
More information about the build-dev
mailing list