JDK 9 RFR of JDK-8031747: Add overloads lint warning to build of jdk repository

Erik Joelsson erik.joelsson at oracle.com
Wed Jan 15 10:37:00 UTC 2014


Looks good to me.

/Erik

On 2014-01-15 03:07, Joe Darcy wrote:
> Hello,
>
> With the lint warnings cleanup continuing, we are close to ridding the 
> jdk repository of the "overloads" warning; remaining work there is out 
> for review (JDK-8031550: Fix overloads lint warnings in client code).
>
> Once that fix gets pushed AND if a jprt build of the full open + 
> closed forest is successful, I like to push the patch below which adds 
> "overloads" to the list of lint warnings enabled in the jdk repo.
>
> Thanks,
>
> -Joe
>
> diff -r a62f87a1d65d make/Setup.gmk
> --- a/make/Setup.gmk    Tue Jan 14 13:52:23 2014 -0800
> +++ b/make/Setup.gmk    Tue Jan 14 18:06:03 2014 -0800
> @@ -1,5 +1,5 @@
>  #
> -# Copyright (c) 2011, 2013, Oracle and/or its affiliates. All rights 
> reserved.
> +# Copyright (c) 2011, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>  # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  #
>  # This code is free software; you can redistribute it and/or modify it
> @@ -27,7 +27,7 @@
>
>  # To build with all warnings enabled, do the following:
>  # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
> -JAVAC_WARNINGS := 
> -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,try,varargs 
> -Werror
> +JAVAC_WARNINGS := 
> -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,overloads,try,varargs 
> -Werror
>
>  # Any java code executed during a JDK build to build other parts of 
> the JDK must be
>  # executed by the bootstrap JDK (probably with -Xbootclasspath/p: ) 
> and for this
>




More information about the build-dev mailing list