RFR: JDK-8031709: Configure --with-jvm-variants=client, server, x produces default outputdir containing comma

[Dave Pointon]

On Tue, 2014-01-14 at 15:08 +0100, Erik Joelsson wrote:
> Running configure with more than 2 jvm variants causes the default 
> outputdir to contain a comma, which in turn breaks the build in corba. 
> The fix is simple and posted inline:
> 
> diff -r d33e5e1a26e2 common/autoconf/jdk-options.m4
> --- a/common/autoconf/jdk-options.m4
> +++ b/common/autoconf/jdk-options.m4
> @@ -105,7 +105,7 @@
>     fi
> 
>     # Replace the commas with AND for use in the build directory name.
> -  ANDED_JVM_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/^,//' -e 
> 's/,$//' -e 's/,/AND/'`
> +  ANDED_JVM_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/^,//' -e 
> 's/,$//' -e 's/,/AND/g'`
>     COUNT_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/server,/1/' -e 
> 's/client,/1/' -e 's/minimal1,/1/' -e 's/kernel,/1/' -e 's/zero,/1/' -e 
> 's/zeroshark,/1/'`
>     if test "x$COUNT_VARIANTS" != "x,1"; then
>       BUILDING_MULTIPLE_JVM_VARIANTS=yes
> 
> 
> /Erik
> 

Hi Eric ,

Altho' I have no role as a reviewer, it looks good, if not a little
verbose since the commands could be made, IMO, far more readably by
catenating the separate -e options - thus re-writing as ...

ANDED_JVM_VARIANTS=`$ECHO "$JVM_VARIANTS" | $SED -e 's/^,//; s/,$//;
s/,/AND/g'`

I would suggest that the same is true of the setting of COUNT_VARIANTS.

Just my pen'orth FWIW

Rgds ,
-- 
Dave Pointon FIAP MBCS

Now I saw, tho' too late, the folly of beginning a work before we count
the cost and before we we judge rightly of our strength to go thro'
with it - Robinson Crusoe