JDK 9 RFR of 8032048: Add static lint warning to build of jdk repository

Erik Joelsson erik.joelsson at oracle.com
Mon Jan 20 08:37:34 UTC 2014


Looks good. I like the progress being made here!

/Erik

On 2014-01-18 00:44, Joe Darcy wrote:
> Hello,
>
> Another week, another lint warning close to be added to the build of 
> the jdk repo :-)
>
> When the final fix for
>
>     JDK-8032047: Fix static lint warnings in client libraries
>
> is applied, the sources in the jdk repo will be free of warnings in 
> the "static" lint category. Therefore, I'd like to also apply a fix for
>
>     8032048: Add static lint warning to build of jdk repository
>
> as shown in the patch below. I plan to push the fixes for 8032047 and 
> 8032048 together in a single jprt job to make sure some stray static 
> warning doesn't sneak in between.
>
> Thanks,
>
> -Joe
>
> diff -r bf6a98e66486 make/Setup.gmk
> --- a/make/Setup.gmk    Wed Jan 15 11:29:47 2014 -0800
> +++ b/make/Setup.gmk    Fri Jan 17 15:40:45 2014 -0800
> @@ -1,5 +1,5 @@
>  #
> -# Copyright (c) 2011, 2013, Oracle and/or its affiliates. All rights 
> reserved.
> +# Copyright (c) 2011, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>  # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  #
>  # This code is free software; you can redistribute it and/or modify it
> @@ -27,7 +27,7 @@
>
>  # To build with all warnings enabled, do the following:
>  # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
> -JAVAC_WARNINGS := 
> -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,overloads,try,varargs 
> -Werror
> +JAVAC_WARNINGS := 
> -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,overloads,static,try,varargs 
> -Werror
>
>  # Any java code executed during a JDK build to build other parts of 
> the JDK must be
>  # executed by the bootstrap JDK (probably with -Xbootclasspath/p: ) 
> and for this




More information about the build-dev mailing list