RFR: JDK9: 8028407: adjust-mflags.sh failed build with GNU Make 4.0 with -I<path contains j>

Erik Joelsson erik.joelsson at oracle.com
Mon Jan 20 12:54:34 UTC 2014


I suggested the change back then and even though I had to think for a 
while to figure out what it did, it still looks correct.

As for pushing, as a jdk9 committer, it is my understanding that you are 
allowed to push it yourself to Hotspot, as long as you use Jprt and push 
to the correct group repo.

/Erik

On 2014-01-17 21:03, Henry Jen wrote:
> Hi,
>
> This is a follow up on an issue first reported on Nov. 2, the fix had 
> been discussed at that time[1] and works for me.
>
> The issue is that the sed command in adjust-mflags.sh trying to 
> isolate -j switch failed to deal with new MFLAGS format spitted out by 
> gmake 4, where the -I<path> without a space, and so if the path 
> contains 'j', the script is confused.
>
> Here is a webrev for JDK9,
> http://cr.openjdk.java.net/~henryjen/jdk9/8028407/0/
>
> Would like to have a sponsor review and push the change, I am tired of 
> patching this. :)
>
> [1] 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-November/011692.html
>
> Cheers,
> Henry




More information about the build-dev mailing list