RFR: JDK-8022411 Can't override CXX and CC settings with absolute path

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Jan 20 13:47:41 UTC 2014


On 2014-01-20 14:00, Erik Joelsson wrote:
> Looks good, except for one (mostly) style nit:
>
> 142       $1=$SEARCH_LIST
>
> We usually quote the value in shell script. In this case we do know 
> that there are no spaces, but I would still like quotes.

Actually, when I looked closer at the patch, I did not like it. Yeah, I 
know, I posted it. :-) It was an old patch that never made it into jdk8 
that I revived. While it will do what it claims to do, it is not very 
good at informing what it does or very helpful in case of failures. I 
rewrote it, almost completely.

Please review this one instead:
http://cr.openjdk.java.net/~ihse/JDK-8022411-override-CXX-CC-with-absolute-path/webrev.02

/Magnus


>
> /Erik
>
> On 2014-01-20 13:48, Magnus Ihse Bursie wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8022411
>>
>> This is kind of the opposite of JDK-8031669. In that bug, simple 
>> tools could be overridden with an absolute path, but not with just an 
>> executable in $PATH. This bug is about CC and CXX, which can be 
>> overridden with an executable in $PATH, but not with an absolute path.
>>
>> Webrev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8022411-override-CXX-CC-with-absolute-path/webrev.01
>>
>> /Magnus
>>
>




More information about the build-dev mailing list