RFR: JDK-8032217: failure in man page processing

[David Holmes]

Hi Erik,

On 21/01/2014 6:51 PM, Erik Joelsson wrote:
> This is for jdk8 and is quite urgent. A problem with man page handling
> in certain (Oracle) build configurations was discovered following my
> last change in the area. This patch moves the remaining logic for closed
> man pages to the closed Images.gmk to keep it all in the same place. It
> also changes some := into = and moves the include point of the closed
> file to enable the needed overrides to work.

This looks fine to me.

> On a side note, making the open makefiles both clear, readable,
> effective and easily overridable is something I would like to address in
> 9. This late in 8, we just need to make it work with minimal changes.

Yeah this is fragile but I'm not sure there is a general solution. The 
positioning of the includes has been determined by current needs, but as 
soon as you have a new requirement that requires a conflicting include 
location then you are stuck.

Cheers,
David

> Webrev: http://cr.openjdk.java.net/~erikj/8032217/webrev.jdk.01/
>
> /Erik