URGENT: RFR: JDK-8032632: Wrong version for the first jdk8 fcs build

David Katleman (Oracle) david.katleman at oracle.com
Fri Jan 24 09:35:25 UTC 2014


On 1/24/2014 1:12 AM, Erik Joelsson wrote:
> Please review this simple fix for JDK8. When building the first fcs 
> build, a version string error was discovered. The fix is simple.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8032632/webrev.root.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8032632
>
> This fix restores the logic to the way it works in JDK7 where it looks 
> like this in jdk/make/common/shared/Defs.gmk:
>
> ifneq ($(MILESTONE),fcs)
>   RELEASE      = $(JDK_VERSION)-$(MILESTONE)$(BUILD_VARIANT_RELEASE)
> else
>   RELEASE      = $(JDK_VERSION)$(BUILD_VARIANT_RELEASE)
> endif
>
> Note that MILESTONE is never empty in either 7 or 8 because it's set 
> to "internal" before the conditional in either case, so the current 
> conditional in JDK8 is just wrong.

Change looks correct.   I didn't see any other MILESTONE reference that 
needs to be updated in addition.

Approved.

         Dave




More information about the build-dev mailing list