RFR: JDK-8033236 Update GensrcCharsetMapping.gmk to build-infra standards

Mike Duigou mike.duigou at oracle.com
Fri Jan 31 19:01:17 UTC 2014


I can't verify that the changes are correct but the resulting build does seem to work for me.

Can you remove this (now) inaccurate comment in Hasher.java :

  46     // This class cannot, sadly, make use of 1.5 features since it must be
  47     // compiled and run with the bootstrap JDK, which is 1.4.2.

Mike


On Jan 30 2014, at 06:18 , Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:

> The file GensrcCharsetMapping.gmk was not properly converted from the old build system.
> 
> This leads to unneccessary output, incorrect dependencies, missed chances for parallelization. It also breaks certain attempts to run static code analyzers such as Parfait.
> 
> This change introduces the new API TextFileProcessing into jdk9. It's been in the build-infra project for a while. Similar to the compile constructs, we can setup a file (or a bunch of files) which needs different kinds of text transformations. In this case, only the INCLUDE functionality is used.
> 
> This is also the first in hopefully a series of patches that will try to bring some order into the mess of generated/processed files. The following rules have been used:
> * Files that are almost java source files, but needs some text processing, should be named "Foo.java.template" and live in the correct place in src/classes.
> * Files that provides data to any gensrc action, but that are not at all java source code, should live in make/data/<descriptive dir>.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8033236
> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8033236-update-gensrc-charset-mapping-gmk/webrev.01/
> 
> /Magnus
> 




More information about the build-dev mailing list