make(1) file structure design/usage docs ?
pointo1d
pointo1d at gmail.com
Fri Jul 11 14:39:57 UTC 2014
Hiya Volker ,
On 11/07/14 13:09, Volker Simonis wrote:
> On Fri, Jul 11, 2014 at 1:56 PM, David Holmes <david.holmes at oracle.com> wrote:
>> On 11/07/2014 9:36 PM, pointo1d wrote:
>>> TFT David ,
>>>
>>> On 11/07/14 06:01, David Holmes wrote:
>>>> On 11/07/2014 2:09 AM, pointo1d wrote:
>>>> <snip
>> This is the following problem: "8026964: Building with an IBM J9 boot
>> jdk requires special settings for BOOT_RTJAR" I had a patch for it:
>> http://cr.openjdk.java.net/~simonis/webrevs/8026964.v2/
>> http://cr.openjdk.java.net/~simonis/webrevs/8026964.jdk/ which wasn't
>> accepted because it led to problems with the MinGW build and I didn't
>> had time to investigate that problem further (see this mail thread:
>> http://mail.openjdk.java.net/pipermail/build-dev/2013-November/thread.html#11108)
>> I'm ready to resume working on it if there's a real need.
>> <snip
I'm afraid that the problem lies elsewhere - I've already locally
implemented my version of the same, or similar, patch (as discussed last
year, IIRC) - the changes I've made look like ...
diff --git a/common/autoconf/boot-jdk.m4 b/common/autoconf/boot-jdk.m4
--- a/common/autoconf/boot-jdk.m4
+++ b/common/autoconf/boot-jdk.m4
@@ -258,15 +258,13 @@
AC_MSG_ERROR([Cannot continue])
fi
- # Setup proper paths for what we found
- BOOT_RTJAR="$BOOT_JDK/jre/lib/rt.jar"
- if test ! -f "$BOOT_RTJAR"; then
- # On MacOSX it is called classes.jar
- BOOT_RTJAR="$BOOT_JDK/../Classes/classes.jar"
- if test -f "$BOOT_RTJAR"; then
- # Remove the ..
- BOOT_RTJAR="`cd ${BOOT_RTJAR%/*} && pwd`/${BOOT_RTJAR##*/}"
- fi
+ # Setup proper paths for what we found - using the jvm itself
+ path_sep="`$BOOT_JDK/bin/java -XshowSettings:properties 2>&1 | $SED
-ne '/path.separator/s,.*= *,,p'`"
+ BOOT_RTJAR="`$BOOT_JDK/bin/java -XshowSettings:properties 2>&1 |
+ $SED -ne '/sun.boot.class.path/,/=/{ s,.* *,,; H }
+ ${ x; s,\n,'$path_sep',g; p }'`"
+ if test "x$OPENJDK_TARGET_OS" = xwindows; then
+ BOOT_RTJAR=`cygpath -u -p "$BOOT_RTJAR" | $TR ':' ';'`
fi
BOOT_TOOLSJAR="$BOOT_JDK/lib/tools.jar"
BOOT_JDK="$BOOT_JDK"
To my mind, this looks a little cleaner and, better still, it avoids the
'[]' shenanigans you found.
Best rgds ,
--
Dave Pointon FIAP MBCS - Contractor engaged by IBM
Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe
More information about the build-dev
mailing list