JDK 9 RFR of 8044715: Add finally lint warning to build of jdk repository

Tim Bell tim.bell at oracle.com
Tue Jun 3 18:45:35 UTC 2014


Looks good to me as well-

Tim

On 06/03/14 18:14, Henry Jen wrote:
> +1. Not a "R"eviewer.
>
> Cheers,
> Henry
>
> On 06/03/2014 11:07 AM, Joe Darcy wrote:
>> Hello,
>>
>> I've started looking at clearing the javac "finally" lint category from
>> the JDK sources. Once that is done, please review the corresponding
>> makefile change to enable the warning the build:
>>
>> diff -r cb15bc14c26a make/Setup.gmk
>> --- a/make/Setup.gmk    Mon Jun 02 19:49:57 2014 +0400
>> +++ b/make/Setup.gmk    Tue Jun 03 11:06:19 2014 -0700
>> @@ -27,7 +27,7 @@
>>
>>   # To build with all warnings enabled, do the following:
>>   # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
>> -JAVAC_WARNINGS :=
>> -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,cast,classfile,dep-ann,divzero,empty,fallthrough,overloads,serial,static,try,varargs 
>>
>> -Werror
>> +JAVAC_WARNINGS :=
>> -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,cast,classfile,dep-ann,divzero,empty,fallthrough,finally,overloads,serial,static,try,varargs 
>>
>> -Werror
>>
>>   # Any java code executed during a JDK build to build other parts of
>> the JDK must be
>>   # executed by the bootstrap JDK (probably with -Xbootclasspath/p: )
>> and for this
>>
>> Thanks,
>>
>> -Joe




More information about the build-dev mailing list