running compiler JCK tests from toplevel makefile

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Jun 5 17:37:18 UTC 2014


Hi,
I've spent some time investigating why jck compiler tests could not be 
launched from toplevel make - i.e. using

make test TEST=langtools_jck-compiler

Turns out that langtools makefile expects certain variables, while the 
build provide others, and those are not correctly wired up. On top of 
that, manually setting an extra make variable (for JCK_HOME) would have 
no effect, as such variable would not be propagated by the make pipeline 
(toplevel make -> test/Makefile -> langtools/test/Makefile).

The following patch seems to fix the issue - should I charge forward 
with it?

diff -r 7d27dbb50d95 test/Makefile
--- a/test/Makefile    Wed Jun 04 10:03:17 2014 -0700
+++ b/test/Makefile    Thu Jun 05 15:48:54 2014 +0100
@@ -58,7 +58,7 @@

  # Test targets
  langtools_% :
-    @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), 
JT_JAVA=$(PRODUCT_HOME) JTREG_HOME=$(JT_HOME) TEST="$(subst 
langtools_,,$@)" $(subst langtools_,,$@))
+    @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), 
JCK_HOME=$(JCK_HOME) TESTJAVA=$(PRODUCT_HOME) JT_JAVA=$(PRODUCT_HOME) 
JCK_CONCURRENCY=$(CONCURRENCY) JTREG_HOME=$(JT_HOME) TEST="$(subst 
langtools_,,$@)" $(subst langtools_,,$@))

  jdk_% core_%s svc_%:
      @$(NO_STOPPING)$(call SUBDIR_TEST, $(JDK_DIR), TEST="$@" $@)


Maurizio



More information about the build-dev mailing list