RFR: JDK-8036079 : (s) --with-boot-jdk-jvmargs configure options are ignored

Erik Joelsson erik.joelsson at oracle.com
Mon Mar 3 09:46:36 UTC 2014


Looks good to me.

/Erik

On 2014-02-28 20:53, Mike Duigou wrote:
> Hello all;
>
> Currently the parameter passed to configure --with-bootjdk-jvmargs is ignored. This changeset improves(*) the handling of the args.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8036079/0/webrev/
>
> I also cleaned up the defaults slightly to better capture the intent of the tests. ie. check for host OS build bits rather than specific platforms.
>
> JAVA_FLAGS in the spec.gmk.in was previously defined by AC_SUBST from the BOOT_JDK_JVMARGS value. It is now AC_SUBST from JAVA_FLAGS though both JAVA_FLAGS and BOOT_JDK_JVMARGS currently have the same value.
>
> (*) It is reasonable to debate whether defaults applied by the configure script should be inserted in BOOTJDK_SETUP_BOOT_JDK_ARGUMENTS as JVM flags. The heap maximum size and stack size will hopefully be revisited via JDK-8007327
>
> Mike




More information about the build-dev mailing list