RFR: JDK-8037483: issue with the crypto / sec zip unzipping in the jdk8 build

Tim Bell tim.bell at oracle.com
Tue Mar 18 15:04:38 UTC 2014


Hi Erik:

> On 2014-03-18 11:42, Erik Joelsson wrote:
>> Please review this very simple fix to unzipping pre built security 
>> classes. When building incrementally, unzip will go into interactive 
>> mode and ask if it should overwrite files. The fix is to add -q -o to 
>> the unzip line as is done on all other invocations of unzip.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8037483
>> Patch inline:
>> diff -r a94a8944bd2b make/Import.gmk
>> --- a/make/Import.gmk
>> +++ b/make/Import.gmk
>> @@ -252,7 +252,7 @@
>>      $(ECHO) Unzipping $(<F)
>>      $(MKDIR) -p $(@D)
>>      $(RM) $@
>> -    ($(CD) $(JDK_OUTPUTDIR) && $(UNZIP) $< > $@.tmp)
>> +    ($(CD) $(JDK_OUTPUTDIR) && $(UNZIP) -q -o $< > $@.tmp)
>>      $(MV) $@.tmp $@
>>  endef
>
> Looks good to me.
>
> /Magnus

Looks good to me as well.

Tim




More information about the build-dev mailing list