RFR (M): 8036767 PPC64: Support for little endian execution model
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Mon Mar 24 21:32:31 UTC 2014
Hi,
builds and runs on ppc linux be / aix.
Best regards,
Goetz.
-----Original Message-----
From: Alexander Smundak [mailto:asmundak at google.com]
Sent: Monday, March 24, 2014 9:10 PM
To: David Holmes
Cc: Lindenmaier, Goetz; build-dev; HotSpot Open Source Developers
Subject: Re: RFR (M): 8036767 PPC64: Support for little endian execution model
Done. Uploaded
http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.05
On Sun, Mar 23, 2014 at 8:37 PM, David Holmes <david.holmes at oracle.com> wrote:
> On 22/03/2014 10:47 AM, Alexander Smundak wrote:
>>
>> On Fri, Mar 21, 2014 at 2:55 PM, Lindenmaier, Goetz
>> <goetz.lindenmaier at sap.com> wrote:
>>>
>>> My build ran into the 'little' case below, as I understand because ' big'
>>> was compared
>>> with 'big'. Make is strange ...
>>
>>
>> Removed the spaces, please take a look at
>> http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.04
>
>
> Stylistically the hotspot makefiles test a variable/expression against a
> value/constant not the other way around. So:
>
> ifeq (undefined,$(origin OPENJDK_TARGET_CPU_ENDIAN))
>
> becomes
>
> ifeq ($(origin OPENJDK_TARGET_CPU_ENDIAN),undefined)
>
> and the same for all the other comparisons you have added.
>
>
> Sorry.
>
> David
>
More information about the build-dev
mailing list