RFR (M): 8036767 PPC64: Support for little endian execution model

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Mar 26 07:07:18 UTC 2014


I have not seen it before, but that webrev contains a modification of autoconf-config.guess, which is not okay. That file is copied directly from the autoconf project and should not be modified.

If that script is not working properly, a correction can be made in the config.guess wrapper. See existing code there for how it can be done.

/Magnus

> On 26 mar 2014, at 01:00, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> I mean build changes in top directory:
> 
> http://cr.openjdk.java.net/~martin/asmundak/8036767/webrev.01/
> 
> Thanks,
> Vladimir
> 
>> On 3/25/14 4:18 PM, Vladimir Kozlov wrote:
>> I assume jdk changes are reviewed by Magnus. Please, confirm.
>> 
>> Changes require a regeneration of generated-configure.sh files.
>> 
>> I am going to push jdk(top) changes into jdk9/hs-comp and will ask
>> gatekeepers to push it up later.
>> 
>> JDK control build testing is running in JPRT now.
>> 
>> Thanks,
>> Vladimir
>> 
>>> On 3/25/14 12:41 PM, Vladimir Kozlov wrote:
>>> I will push changes from webrev.05 into hs-comp/hotspot
>>> 
>>> Where I should push jdk changes (jdk9/dev/ or hs-comp)?:
>>> 
>>> http://cr.openjdk.java.net/~martin/asmundak/8036767/webrev.01/
>>> 
>>> Thanks,
>>> Vladimir
>>> 
>>>> On 3/25/14 3:32 AM, David Holmes wrote:
>>>> Thanks. Build side looks fine to me.
>>>> 
>>>> David
>>>> 
>>>>> On 25/03/2014 6:09 AM, Alexander Smundak wrote:
>>>>> Done. Uploaded
>>>>> http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.05
>>>>> 
>>>>> On Sun, Mar 23, 2014 at 8:37 PM, David Holmes
>>>>> <david.holmes at oracle.com> wrote:
>>>>>> On 22/03/2014 10:47 AM, Alexander Smundak wrote:
>>>>>>> 
>>>>>>> On Fri, Mar 21, 2014 at 2:55 PM, Lindenmaier, Goetz
>>>>>>> <goetz.lindenmaier at sap.com> wrote:
>>>>>>>> 
>>>>>>>> My build ran into the 'little' case below, as I understand because
>>>>>>>> ' big'
>>>>>>>> was compared
>>>>>>>> with 'big'.  Make is strange ...
>>>>>>> 
>>>>>>> 
>>>>>>> Removed the spaces, please take a look at
>>>>>>> http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.04
>>>>>> 
>>>>>> 
>>>>>> Stylistically the hotspot makefiles test a variable/expression
>>>>>> against a
>>>>>> value/constant not the other way around. So:
>>>>>> 
>>>>>>  ifeq (undefined,$(origin OPENJDK_TARGET_CPU_ENDIAN))
>>>>>> 
>>>>>> becomes
>>>>>> 
>>>>>>  ifeq ($(origin OPENJDK_TARGET_CPU_ENDIAN),undefined)
>>>>>> 
>>>>>> and the same for all the other comparisons you have added.
>>>>>> 
>>>>>> 
>>>>>> Sorry.
>>>>>> 
>>>>>> David
>>>>>> 



More information about the build-dev mailing list