JDK-8037953 configure usability: Should provide better details on imported hotspot

David Holmes david.holmes at oracle.com
Mon May 12 07:16:46 UTC 2014


On 9/05/2014 10:32 PM, pointo1d wrote:
> Hi all ,
>
> By way of a heads-up, I deem that the nature and relative size of the
> change (incorporating the comments from both Erik & David) now requires
> a webrev, so one has been generated and is awaiting hosting up on
> openjdk - of which further news as and when available.
>
> On the point of which, I note that the contributor guide
> (http://openjdk.java.net/contribute/) claims that patches may be either
> in the body of, or attached to, e-mails but as we all know, attachments
> are removed - is this because they are ZIP files, or are ALL attachments
> removed be as it may and the guide is wrong in this respect ?

All attachments are no longer removed, but likely zip files still are. 
If the patch is big enough to need a webrev the webrev should be hosted 
on cr.openjdk.java.net - attaching a webrev (even if permitted is a 
pain-in-the-butt for reviewers).

David H.
-------

> Rgds ,
>
> --
> ​Dave Pointon FIAP MBCS
>
> Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe
>



More information about the build-dev mailing list