JDK-8037953 configure usability: Should provide better details on imported hotspot

[David Holmes]

On 12/05/2014 8:19 PM, pointo1d wrote:
>
> On 12/05/14 10:50, David Holmes wrote:
>> Also this appears to need the x to be quoted "x"
>>
>> +   if test "x$with_import_hotspot" != x; then
>>
>> at least that is the normal pattern (it may not be strictly necessary).
>
> Hmm, I was following, or attempting to follow, the 'convention' as
> illustrated elsewhere in the file e.g. the previous test, where the
> single char 'x' is not quoted. I have to say that the quoting of string
> constants not containing white space is a little OTT and as you suggest,
> not at all necessary - even in the most basic of Bourne shells.

Sorry, I had it in my head that the normal pattern was to always quote 
and the test immediately preceding the change seemed to confirm my thinking

if test "x$OPENJDK_BUILD_OS" = "xwindows"; then

but as you say this is not necessary and indeed not the common pattern.

David

> <snip>
>
> Rgds ,
>