[OpenJDK 2D-Dev] <AWT Dev> RFR: Allow using the system libjpeg
Phil Race
philip.race at oracle.com
Tue May 20 17:18:44 UTC 2014
I'm going to apply the patch and run it through open + closed builds
cross-platforms ..
-phil..
On 5/20/2014 10:15 AM, Anthony Petrov wrote:
> Thanks for the update, Omair. The fix looks good to me now.
>
> --
> best regards,
> Anthony
>
> On 5/20/2014 9:11 PM, Omair Majid wrote:
>> Hi,
>>
>> Updated webrevs:
>> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/
>> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/
>>
>> * Anthony Petrov <anthony.petrov at oracle.com> [2014-05-19 14:42]:
>>> make/lib/Awt2dLibraries.gmk
>>>> 1236 LIBJPEG_CFLAGS :=
>>>> $(JDK_TOPDIR)/src/share/native/sun/awt/image/jpeg
>>>
>>> Since these are compiler flags, I suppose this should read
>>> "-I<path>", not
>>> just "<path>".
>>
>> Yes, it should. I wonder how my compiler accepted that.
>>
>>> Did you build with --with-jpeg=bundled ? Can the resulting JDK read
>>> jpeg
>>> files?
>>
>> I did. I tested both combinations and made sure both the splash screen
>> and javax.swing.ImageIcon could display jpegs files with the first
>> webrev I posted.
>>
>> Thanks,
>> Omair
>>
More information about the build-dev
mailing list